Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait before present option #1146

Merged

Conversation

bartosz-muszarski-arm
Copy link
Contributor

Force wait on completion of queue operations for all queues before calling Present. This is needed for accurate acquisition of instrumentation data on some platforms.

@ci-tester-lunarg
Copy link

Author bartosz-muszarski-arm not on autobuild list. Waiting for curator authorization before starting CI build.

Copy link
Contributor

@andrew-lunarg andrew-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice, tight little change.

Only question I have is whether it needs to account for alternate frame delimiters for platforms where images get to eyeballs without going through presents. Doing so could be a later addition though if it doesn't matter for the platforms the author cares about / is able to test on easily.

@bartosz-muszarski-arm
Copy link
Contributor Author

Looks like a nice, tight little change.

Only question I have is whether it needs to account for alternate frame delimiters for platforms where images get to eyeballs without going through presents. Doing so could be a later addition though if it doesn't matter for the platforms the author cares about / is able to test on easily.

We can add this later, as you said it's not something we can test easily now

@bradgrantham-lunarg
Copy link
Contributor

We can add this later, as you said it's not something we can test easily now

Can you test this against #1138?

@bradgrantham-lunarg bradgrantham-lunarg added the P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash. label Oct 30, 2023
Force wait on completion of queue operations for all queues before calling Present.
This is needed for accurate acquisition of instrumentation data on some platforms.

Change-Id: Ie5c07df95ad4420ed516f6f59c719d91887fa73a
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 177072.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4075 running.

Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents of the PR needed rebasing/cleanup to work with current dev. I did have to redo how the device handle was used to get the dispatch table to make it function.

The design is reasonable - force a vkDeviceWaitIdle on every vkQueuePresentKHR.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4075 passed.

@charles-lunarg charles-lunarg merged commit 3ac2765 into LunarG:dev May 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants