-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wait before present option #1146
Add wait before present option #1146
Conversation
Author bartosz-muszarski-arm not on autobuild list. Waiting for curator authorization before starting CI build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice, tight little change.
Only question I have is whether it needs to account for alternate frame delimiters for platforms where images get to eyeballs without going through presents. Doing so could be a later addition though if it doesn't matter for the platforms the author cares about / is able to test on easily.
We can add this later, as you said it's not something we can test easily now |
Can you test this against #1138? |
Force wait on completion of queue operations for all queues before calling Present. This is needed for accurate acquisition of instrumentation data on some platforms. Change-Id: Ie5c07df95ad4420ed516f6f59c719d91887fa73a
0b71233
to
54d7296
Compare
CI gfxreconstruct build queued with queue ID 177072. |
CI gfxreconstruct build # 4075 running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contents of the PR needed rebasing/cleanup to work with current dev. I did have to redo how the device handle was used to get the dispatch table to make it function.
The design is reasonable - force a vkDeviceWaitIdle on every vkQueuePresentKHR.
CI gfxreconstruct build # 4075 passed. |
Force wait on completion of queue operations for all queues before calling Present. This is needed for accurate acquisition of instrumentation data on some platforms.